Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADBDEV-6776 Restore PXF unit tests for external table #145

Open
wants to merge 1 commit into
base: pxf-6.x
Choose a base branch
from

Conversation

dkovalev1
Copy link

PXF external table component contains a directory with unit tests. These tests
have not been updated for a while and seem to be broken now. However, ongoing
development can benefit from having unit tests ready to use.

The problem with these tests is that PXF heavily uses database internals, such
as strings, memory management, transaction states, etc. While PXF was part of
the core distribution, this was not an issue since the tests were integrated
into the GP unit test system. However, when PXF became an independent component
without references to the database source code, the problem arose. This was
perhaps the main reason the tests were abandoned.

This commit enables the tests to be built and run. However, many of the tests
remain disabled as the environment has changed significantly, and a considerable
amount of effort is still required to resurrect them. These tests have been
commented out, and compiler warnings will serve as a reminder that this work is
not yet finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant