ADBDEV-6159: Add support pushdown for timestamp with time zone data type
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If we don't know exactly the type of the external database we are connecting to, we use Postgres syntaxes by default to create pushdown filter. As we added supporting of the `timestamp with time zone` type for pushdown, we should know exactly how to convert the string to `timestamp with time zone` type for different databases.
iamlapa
approved these changes
Nov 18, 2024
vladimir-zaytsev
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support pushdown for
timestamp with time zonedata type for Postgres, Oracle, Microsoft SQL Server databases. If the external database supports PostgreSql syntaxes, it is also possible to use pushdown withtimestamp with time zone;Added additional 'OTHER' type of DBMS. If we don't know exactly the type of the external database we are connecting to, we use Postgres syntaxes by default to create pushdown filter. As we added supporting of the
timestamp with time zonetype for pushdown, we should know exactly how to convert the string totimestamp with time zonetype for different databases.