ADBDEV-6682: Implement TLS options for PXF external tables #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andr-sokolov
changed the title
andr-sokolov
commented
Dec 5, 2024
| { | ||
| const char *proto = get_pxf_protocol(); | ||
|
|
||
| if (proto && strcmp(proto, "https") == 0 ) |
There was a problem hiding this comment.
Suggested change
| if (proto && strcmp(proto, "https") == 0 ) | |
| if (proto && strcmp(proto, "https") == 0) |
andr-sokolov
commented
Dec 5, 2024
| { | ||
| const char *proto = getenv(ENV_PXF_PROTOCOL); | ||
|
|
||
| if (proto == NULL) { |
There was a problem hiding this comment.
An opening bracket after if should be in the next line - this is code style of PostgreSQL. As an alternative the brackets can be removed here
andr-sokolov
commented
Dec 5, 2024
Comment on lines
+200
to
+207
| long verifypeer = PXF_DEFAULT_SSL_VERIFY_PEER; | ||
|
|
||
| if (verify_peer_var != NULL) | ||
| { | ||
| verifypeer = atol(verify_peer_var); | ||
| } | ||
|
|
||
| return verifypeer; |
There was a problem hiding this comment.
I suggest to remove the verifypeer variable
Suggested change
| long verifypeer = PXF_DEFAULT_SSL_VERIFY_PEER; | |
| if (verify_peer_var != NULL) | |
| { | |
| verifypeer = atol(verify_peer_var); | |
| } | |
| return verifypeer; | |
| if (verify_peer_var != NULL) | |
| { | |
| return atol(verify_peer_var); | |
| } | |
| return PXF_DEFAULT_SSL_VERIFY_PEER; |
RekGRpth
reviewed
Dec 9, 2024
| @@ -116,6 +128,85 @@ get_pxf_port(void) | |||
| return port; | |||
| } | |||
|
|
|||
| const char * | |||
| get_pxf_ssl_keypasswd(void) | |||
There was a problem hiding this comment.
how about only two functions
const char *getenv_char(const char *name, const char *default);
long getenv_long(const char *name, long default);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS options implemented for PXF external tables
The requirement for using TLS is implemented for PXF external tables. The
communication takes place between the segment node and the PXF server and is
pointless without the PXF server. The testing shall be done in conjunction with
PXF server changes and is out of scope for this commit.