ADBDEV-6065: Improve logic of fragment distribution #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor fragmenter service; - Add strategies for fragment distribution - Add `improved-round-robin` strategy
iamlapa
previously approved these changes
Aug 14, 2024
# Conflicts: # automation/pom.xml
# Conflicts: # automation/pom.xml
xardazzzzzz
reviewed
Sep 12, 2024
| int shiftedIndex = context.getGpSessionId() % context.getTotalSegments() + context.getGpCommandCount(); | ||
| List<Fragment> filteredFragments = new ArrayList<>((int) Math.ceil((double) fragments.size() / context.getTotalSegments())); | ||
| for (Fragment fragment : fragments) { | ||
| if (context.getSegmentId() == (shiftedIndex % context.getTotalSegments())) { |
There was a problem hiding this comment.
I don't see that we take the same mod twice. If you mean that the first is int shiftedIndex = context.getGpSessionId() % context.getTotalSegments() + context.getGpCommandCount and the second is shiftedIndex % context.getTotalSegments():
The first one is responsible for the shifting taking into account command count and the second one is responsible for getting segment for the fragment.
xardazzzzzz
previously approved these changes
Sep 12, 2024
# Conflicts: # automation/src/test/java/org/greenplum/pxf/automation/arenadata/FragmentDistributionTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved-round-robinstrategy;