Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADBDEV-6834: Fix modified GUCs when starting a new slice #1149

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

RekGRpth
Copy link
Member

@RekGRpth RekGRpth commented Dec 6, 2024

Fix modified GUCs when starting a new slice

The commit 2b821ea added installation of modified GUCs when starting a new
slice. However, it was not taken into account that some GUCs, for example,
default_tablespace, temp_tablespaces and temp_spill_files_tablespaces, cannot
contain invalid values ​​for a new connection, although this does not cause
problems for the current connection. This patch fixes an issue by using the
PGC_S_TEST option instead of PGC_S_SESSION when setting modified GUCs when
starting a new slice.

@RekGRpth RekGRpth changed the title ADBDEV-6834; Fix modified GUCs when starting a new slice ADBDEV-6834: Fix modified GUCs when starting a new slice Dec 6, 2024
@RekGRpth RekGRpth marked this pull request as ready for review December 7, 2024 03:46
@bandetto
Copy link
Member

Can you please add something like 7X to the title to differentiate between two PRs?

@RekGRpth
Copy link
Member Author

RekGRpth commented Dec 11, 2024

Can you please add something like 7X to the title to differentiate between two PRs?

I suggested adding 6X and 7X labels, but this suggestion was rejected because "it's already clear which version the pull request is being made for."

screen

@bandetto
Copy link
Member

It still requires to hoverover the PR label or waiting for the page to load which is mildly inconvenient. Alright.

bandetto
bandetto previously approved these changes Dec 11, 2024
@whitehawk
Copy link

Why don't you wait for #1148 to complete and do a cherry-pick? I think it is better, as it will allow to preserve traceability to #1148, where discussion is more detailed.

@RekGRpth
Copy link
Member Author

RekGRpth commented Dec 12, 2024

Why don't you wait for #1148 to complete and do a cherry-pick? I think it is better, as it will allow to preserve traceability to #1148, where discussion is more detailed.

Done.

@RekGRpth RekGRpth marked this pull request as draft December 12, 2024 05:41
The commit fe973d0 added installation of modified GUCs when starting a new
slice. However, it was not taken into account that some GUCs, for example,
default_tablespace, temp_tablespaces and temp_spill_files_tablespaces, cannot
contain invalid values ​​for a new connection, although this does not cause
problems for the current connection. This patch fixes an issue by using the
PGC_S_TEST option instead of PGC_S_SESSION when setting modified GUCs when
starting a new slice.

Ticket: ADBDEV-6834
(cherry picked from commit 4c4068f)
@RekGRpth RekGRpth marked this pull request as ready for review December 12, 2024 08:58
@RekGRpth RekGRpth enabled auto-merge (rebase) December 12, 2024 11:55
@RekGRpth RekGRpth merged commit b87fecb into adb-7.2.0 Dec 12, 2024
5 checks passed
@RekGRpth RekGRpth deleted the ADBDEV-6834 branch December 12, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants