forked from greenplum-db/gpdb-archive
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV-6834: Fix modified GUCs when starting a new slice #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RekGRpth
changed the title
ADBDEV-6834; Fix modified GUCs when starting a new slice
ADBDEV-6834: Fix modified GUCs when starting a new slice
Dec 6, 2024
Can you please add something like |
It still requires to hoverover the PR label or waiting for the page to load which is mildly inconvenient. Alright. |
bandetto
previously approved these changes
Dec 11, 2024
The commit fe973d0 added installation of modified GUCs when starting a new slice. However, it was not taken into account that some GUCs, for example, default_tablespace, temp_tablespaces and temp_spill_files_tablespaces, cannot contain invalid values for a new connection, although this does not cause problems for the current connection. This patch fixes an issue by using the PGC_S_TEST option instead of PGC_S_SESSION when setting modified GUCs when starting a new slice. Ticket: ADBDEV-6834 (cherry picked from commit 4c4068f)
RekGRpth
force-pushed
the
ADBDEV-6834
branch
from
December 12, 2024 08:57
0c7be5f
to
aaadd4a
Compare
whitehawk
approved these changes
Dec 12, 2024
bandetto
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix modified GUCs when starting a new slice
The commit 2b821ea added installation of modified GUCs when starting a new
slice. However, it was not taken into account that some GUCs, for example,
default_tablespace, temp_tablespaces and temp_spill_files_tablespaces, cannot
contain invalid values for a new connection, although this does not cause
problems for the current connection. This patch fixes an issue by using the
PGC_S_TEST option instead of PGC_S_SESSION when setting modified GUCs when
starting a new slice.