-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADBDEV 6061 Add test for doRestoreAgent in gpbackup #102
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The same should be done for |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Roman Eskin <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
bender build |
if !h.started { | ||
h.started = true | ||
} else { | ||
h.currentStep++ | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be remove started
and put h.currentStep++
before return ret
?
Expect(h.currentStep).To(BeNumerically("<", len(h.expectedSteps))) | ||
ret := h.expectedSteps[h.currentStep] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expect(h.currentStep).To(BeNumerically("<", len(h.expectedSteps))) | |
ret := h.expectedSteps[h.currentStep] | |
ret := h.getCurStep() |
@@ -26,10 +25,9 @@ import ( | |||
var ( | |||
CleanupGroup *sync.WaitGroup | |||
version string | |||
pipesMap map[string]bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused var?
endbyte: %d | ||
`, dataLength+18, dataLength+18+18) | ||
fToc, err := os.Create(tocFile) | ||
Expect(err).ShouldNot(HaveOccurred()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if error occurred then file is not closed!
*tocFile = fmt.Sprintf("%stest_toc.yaml", testDir) | ||
writeTestTOC(*tocFile) | ||
defer func() { | ||
_ = os.Remove(*tocFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if writeTestTOC
does not create file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
writeTestTOC
has
fToc, err := os.Create(tocFile)
Expect(err).ShouldNot(HaveOccurred())
```, then it will fail inside `writeTestTOC`
Add tests for doRestoreAgent with interface mocking.
This PR proposes to add mocking interfaces and unit test for the
doRestoreAgent() function in the gprestore.
When we look at the gprestore code, and into doRestoreAgent() in particular,
there is not so trivial logic which might be difficult to cover with the
end-to-end and integration tests. From the other side this logic relies on
numerous external dependencies which makes unit testing nearly impossible.
This commit proposes using of well-known mocking technique for unit testing of
gpbackup code with an example based on gprestore and doRestoreAgent(). With
interface mocking it becomes possible to:
external dependencies, tests will be more stable
However, this approach only complements existing end-to-end and integration
tests, it's not intended to replace them. The outcome heavily relies on the
clarity and quality of mock interfaces; it's easy to achieve unintended results.
The idea for mocking is to replace complex objects with their test imitation.
Unfortunately, gpbackup is written in solid manner, and it's not possible to
just replace built-in functions. To mitigate it, internal dependencies are split
with introducing of interfaces for dependencies external related to code under
test. Production code is using production interface implementation, while in
testing code we use test implementation, which does do only things related to
the test and return values exactly for the test scenario.
This commit adds the following interfaces:
helper/restore_helper.go
whether the command has already been ended
This is a minimum change for the supplied tests. It's expected that when more
methods or interfaces will be needed they will be created of necessity. The
changes for the interface introduction are minimal and straightforward.
Test logic is located in the helper/helper_test.go.