Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADH-5313] Fix problems during file rename syncing #132

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

tigrulya-exe
Copy link
Member

  • Fixed merging of rename operation during file sync: now InotifyEventApplier generates rename FileDiff for all files related to the rename event from INotify and CopyScheduler merges them to the corresponding file diff chains. In case if there are pending APPEND diffs for the rename source path, scheduler cancels them and recreates with new name. Rename operation itself happens only once for the rename root path regardless of whether it is a file or a directory.
  • Removed the smart.sync.schedule.strategy option, controlling the order of scheduling sync files and left only FIFO strategy to avoid some corner cases where consistency is broken.
  • Made delete action idempotent

@tigrulya-exe tigrulya-exe force-pushed the bugfix/ADH-5313-fix-append-delete-chain branch from ef2dd0b to 1d5b38c Compare November 18, 2024 13:57
@tigrulya-exe tigrulya-exe changed the title [ADH-5348] Fix problems during file rename syncing [ADH-5313] Fix problems during file rename syncing Nov 22, 2024
iamlapa and others added 3 commits November 25, 2024 22:23
…-fill-metastore

[ADH-5351] Use CreateEvent to add information about file to Metastore
@iamlapa iamlapa merged commit e37705c into develop Nov 26, 2024
1 check passed
@iamlapa iamlapa deleted the bugfix/ADH-5313-fix-append-delete-chain branch November 26, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants