Fix the close datepicker with no update situation when manually typing time #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alextepes
changed the title
alextepes
changed the title
Tofandel
reviewed
Dec 3, 2024
| @@ -178,6 +178,7 @@ | |||
| }, | |||
| onClose: function (selectedDates, dateStr, instance) { | |||
| self.$nextTick(function () { // wait for the datepicker to properly update the UI | |||
| self.date = dateStr; | |||
There was a problem hiding this comment.
I think it would make more sense to maybe call this.saveIntoStore onBlur if this.disabled is false
There was a problem hiding this comment.
After testing myself, the onBlur method is never called and this does seem to be the only reliable fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a datepicker problem occurring when manually typing the time.
Related Issues
Fixes #2667