Skip to content

Comments

Avoid copying whole directory on Open in all cases#7909

Open
facchinm wants to merge 1 commit intoarduino:masterfrom
facchinm:copy_directory_on_open_only_if_needed_master
Open

Avoid copying whole directory on Open in all cases#7909
facchinm wants to merge 1 commit intoarduino:masterfrom
facchinm:copy_directory_on_open_only_if_needed_master

Conversation

@facchinm
Copy link
Member

@facchinm facchinm commented Aug 22, 2018 •
edited
Loading

Alternative to #7904, tries to distinguish between

  • click on a single ino file downloaded from the internet (old behaviour applies, directory is created and the file is moved in it)
  • click on an ino file that for some reason is part of a project with the wrong name (eg. it was downloaded as zip from github, so the containing folder names becomes "projectName-master"). In this case if the directory is renamed after prompting the user)
    2018-08-22-112348_1920x1080_scrot

@facchinm facchinm requested a review from cmaglie August 22, 2018 08:24
@facchinm facchinm force-pushed the copy_directory_on_open_only_if_needed_master branch from 38151d6 to 54adc00 Compare August 22, 2018 09:39
@arduino arduino deleted a comment from ArduinoBot Aug 22, 2018
@arduino arduino deleted a comment from ArduinoBot Aug 22, 2018
This was referenced Aug 23, 2018
Closed
Closed
@facchinm facchinm added this to the Release 1.8.7 milestone Aug 27, 2018
@facchinm facchinm modified the milestones: Release 1.8.7, Release 1.8.8 Sep 17, 2018
@sandeepmistry
Copy link
Contributor

sandeepmistry commented Sep 17, 2019

@facchinm are we still interested in moving ahead with these changes?

@facchinm
Copy link
Member Author

facchinm commented Sep 18, 2019

Yes, since the behaviour as of today is wrong 🙂
But maybe the right place to apply this would be the cli (if it enforces the dirName/dirName.ino convention)

@facchinm
Rename sketch folder only if proper name is slightly different
3e3593d 
Takes into account Github-like transformations (projectName becomes projectName-branchName)
Also changes user prompt to specify that it will move a whole folder.
@facchinm facchinm force-pushed the copy_directory_on_open_only_if_needed_master branch from f95d193 to 3e3593d Compare September 18, 2019 07:32
@ArduinoBot
Copy link
Contributor

ArduinoBot commented Sep 18, 2019

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7909-BUILD-890-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7909-BUILD-890-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7909-BUILD-890-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7909-BUILD-890-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-7909-BUILD-890-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@cmaglie cmaglie modified the milestones: Release 1.8.10, Release 1.8.11 Nov 8, 2019
@arduino arduino deleted a comment from ArduinoBot Jun 3, 2020
@arduino arduino deleted a comment from ArduinoBot Jun 3, 2020
@per1234 per1234 mentioned this pull request May 3, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 1.8.14

Development

Successfully merging this pull request may close these issues.

4 participants

@facchinm @sandeepmistry @ArduinoBot @cmaglie