Open
Conversation
Version deprecation resolved
per1234
requested changes
Oct 18, 2024
| run: xvfb-run --auto-servernum --server-args "-screen 0 1024x768x24" ant test -Drunning-from-github-action=1 | ||
| - name: Publish results | ||
| uses: actions/upload-artifact@v1 | ||
| uses: actions/upload-artifact@v3 # Updated from v1 to v3 |
Collaborator
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@v3 # Updated from v1 to v3 | |
| uses: actions/upload-artifact@v3 |
Don't pollute the file with worthless changelog comments. That what we have Git for!!!
It is ridiculous that you made the effort to add this comment, but you didn't make the effort to write a proper Git commit message. Step up your game @VarshiniShreeV.
Contributor
Author
There was a problem hiding this comment.
Thank you for your feedback on the change I made. I appreciate your perspective on keeping the file clean and utilizing Git for tracking changes.
I’ll make sure to improve my commit messages in the future to provide clearer context for the changes made. Your input helps me grow, and I’ll take it into account moving forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version deprecation resolved
All Submissions:
Changes to Core Features:
I updated the upload-artifact action from v1 to v3 to address the deprecation notice issued by GitHub. Using the latest version is essential for maintaining the reliability and security of our CI/CD workflows.
Reasons for the Change:
Deprecation: The v1 version is deprecated and may no longer receive updates or support, which could lead to potential issues in our workflow.
Improved Functionality: The latest version includes enhancements and bug fixes that improve performance and reliability.
Security: Keeping dependencies updated helps protect against vulnerabilities and ensures that we are using the most secure version available.
Compatibility: The newer version is more compatible with other actions and features in GitHub Actions, reducing the risk of future compatibility issues.
By making this change, we ensure our workflow remains efficient and up to date with the latest best practices.