-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Instances of Memory Corruption on Illumos #93
Conversation
Should fix #91 |
Thanks! Just a couple of comments:
Also, could you rename |
Yeah, I agree this should be reworked. I'll work on switching it for whoami 1.5.0, aiming to get that out today.
This should be fine, will aim to get this change in for 1.6.0 since there's already a lot going into 1.5.0.
Where exactly should it be renamed? The platform enum should stay |
Yeah, readme, doc comments and Display impl. Thank you! |
In the future it would be nice to use libc (once an MSRV policy is decided on that's compatible with whoami 1.0's MSRV guarantees) or nix (in whoami 2.1), but for now doing a minimal patch.
Also, supporting Illumos as a tested target.