core/pacman move -mno-omit-leaf-frame-pointer flags to arch specific #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-mno-omit-leaf-frame-pointer is aarch64 specific, using this flag in armv7 will break compilation of everything with gcc and result will error cc: error: unrecognized command-line option ‘-mno-omit-leaf-frame-pointer’; did you mean ‘-fno-omit-frame-pointer’? References: https://gcc.gnu.org/onlinedocs/gcc-15.2.0/gcc/AArch64-Function-Attributes.html#index-omit-leaf-frame-pointer-function-attribute_002c-AArch64 https://gcc.gnu.org/onlinedocs/gcc-15.2.0/gcc/ARM-Function-Attributes.html
Author
|
seems like this a regression form march 2024: https://github.com/archlinuxarm/PKGBUILDs/blame/6c4f047f155988f7bd0a80a6988e1662ed293109/core/pacman/makepkg.conf, and since then each gcc build with edit: sigh, seems like there was even a pr in oct.24: #2151 :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-mno-omit-leaf-frame-pointer is aarch64 specific, using this flag in armv7 will break compilation of everything with gcc and result will error
cc: error: unrecognized command-line option
‘-mno-omit-leaf-frame-pointer’; did you mean ‘-fno-omit-frame-pointer’?
References:
https://gcc.gnu.org/onlinedocs/gcc-15.2.0/gcc/AArch64-Function-Attributes.html#index-omit-leaf-frame-pointer-function-attribute_002c-AArch64 https://gcc.gnu.org/onlinedocs/gcc-15.2.0/gcc/ARM-Function-Attributes.html
in case things gets lost in the way here i am pinging @graysky2 @kmihelich