Skip to content

Conversation

justbispo
Copy link

@justbispo justbispo commented Aug 4, 2025

This fixes #1951.

PR Description:

This PR simply adds support for rEFInd boot manager. I've checked all the places where the boot managers are called to make sure I didn't miss anything.
I've also followed the Arch Wiki page about rEFInd to make sure I made the installation function correct.
Before accepting the PR, I'd like an opinion about a small issue I noticed. I didn't know this but per the Arch Wiki, rEFInd is supposed to use the distro logo but after the installation is finished, it uses the Tux logo. After checking the partitions, it's as it says there, the root partition is of type Linux x86-64 root (/) instead of Linux filesystem. But the installation guide suggests using Linux x86-64 root (/). The Wiki also shows two other fixes, but I don't know if the label can be changed in the rEFInd installation step and copying the distro image seems easy, tho I don't know if it's the best solution
Is this and issue that can be fixed?

Just a note for the future, I'd also like to include refind-btrfs, like grub includes grub-btrfs, to show BTRFS snapshots as boot options, but refind-btrfs isn't in the extra repository.

Tests and Checks

  • I have tested the code!

@justbispo justbispo requested a review from Torxed as a code owner August 4, 2025 00:26
@Torxed
Copy link
Member

Torxed commented Aug 4, 2025

Thank you for this contribution, I'll do some tests with this one before merging in.
While I do those tests, could you fix the ruff formatting complaints?

I have never used refind, so I'll have to test and read about the logo situation :)

I could also look into the possibility to package refind-btrfs for us into extra instead of AUR, I just need to check the build process and see what it does before we do.

@justbispo
Copy link
Author

Done, I thought the pre-commit hook would add the formatting changes to the commit.

@Torxed
Copy link
Member

Torxed commented Aug 4, 2025

Done, I thought the pre-commit hook would add the formatting changes to the commit.

My understanding is that you need to enable them locally, our repo simply contains the hooks that you would need.

@Torxed
Copy link
Member

Torxed commented Aug 27, 2025

I'm still away on a trip and have limited access to proper internet.
So I won't be able to test this (installing packages and what not takes too much data).
This means I don't dare to merge this in for the next minor release that I plan on pushing today.

I still welcome this contribution, just thought I'd let you know why it won't make it in to the next release ~today. But it's coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rEFind as an alternative bootloader
2 participants