Support patterns in outPath for NestedOutputProcessorDecorator #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elpath] [basename]
outputTarget: {
'*|[relpath]/[basename].txt': function () {..}
}
…me tokens (e.g. [yy][mm][dd], ...) example: [relpath]/[basename]/[yyyy][mm][dd]/[basename].[HH][MM][SS].txt or [yyyy][mm][dd]_[HH][MM][SS]/[relpath]/[basename].txt
archfz
reviewed
Jun 6, 2024
| constructor(filePattern, specRoot, decoratedFactory) { | ||
| const parts = filePattern.split('|'); | ||
| // for pattern matching: first part of filePattern has to start with '*|' | ||
| if (parts[0] === "*") { |
There was a problem hiding this comment.
Could you please modify the spacing to use two spaces instead of tabs ?
| @@ -21,7 +29,58 @@ module.exports = class NestedOutputProcessorDecorator { | |||
| } | |||
|
|
|||
| const relativeSpec = path.relative(this.specRoot, spec); | |||
| const outPath = path.join(this.root, relativeSpec.replace(new RegExp(path.extname(relativeSpec) + '$'), `.${this.ext}`)); | |||
|
|
|||
| const parsed = path.parse(relativeSpec); | |||
There was a problem hiding this comment.
This is a big chunk of code that can get its own method.
|
Hi @JohannesMunk . This looks nice. Sorry for feedback only after 2 weeks. I wonder if we should apply this to both nested and non nested output path generation? It would make sense to keep consistency. Besides that this PR needs some test updates, +one case that is actually testing this new feature. Let me know if you need help / direction. |
|
Fyi I have implemented some changes and did some maintenance on certain tests that were broken. You should pull changes from origin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! I tried to minimize changes to implement patterns in output filenames for custom output:
outputTarget: { '*|[relpath]/[basename]/[yyyy][mm][dd]/[basename].[HH][MM][SS].txt': function (allMessages) {..} }outputTarget: { '*|[relpath]/[basename].txt': function () {..} }Supported are these tokens:
The legacy format given as 'path-prefix|extension'
outputTarget: { 'cypress-logs|txt': function () {..} }is translated to pattern:
parts[0]+"/[relpath]/[basename]."+parts[1]Hope this helps someone!