Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style cleanups #56

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Style cleanups #56

merged 9 commits into from
Jan 23, 2025

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Dec 30, 2024 •
edited
Loading

@jacobtylerwalls
Hide injection of selected language under if
ff9c481 
Lingo doesn't implement selecting a language
johnatawnclementawn
johnatawnclementawn requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing some overflow issues with the ValueEditor row
valueEditorOverflow

johnatawnclementawn
johnatawnclementawn approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍🏼

@jacobtylerwalls jacobtylerwalls merged commit 14a9ec4 into main Jan 23, 2025
4 of 5 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/cleanups branch January 23, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnatawnclementawn johnatawnclementawn johnatawnclementawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @johnatawnclementawn