Deduplicate routes #201
Merged
Deduplicate routes #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Jan 31, 2025
| fields = "__all__" | ||
|
|
||
| def validate(self, data): | ||
| data = super().validate(data) | ||
| def validate_appellative_status(self, data): |
There was a problem hiding this comment.
The next thing we're going to want is a similar hook in the resource serializer to ensure that if you're using that, you can run this logic too. I'm still thinking that part through, but at least there's no functionality regression with this because Johnathan's work on labels uses the tile serializer.
aarongundel
approved these changes
Feb 4, 2025
| } else { | ||
| await updateSchemeNote( | ||
| route.params.id as string, | ||
| const updated = await upsertLingoTile( |
There was a problem hiding this comment.
love that this is an upsert.
| @@ -1,12 +1,7 @@ | |||
| import arches from "arches"; | |||
| import Cookies from "js-cookie"; | |||
| import type { | |||
There was a problem hiding this comment.
Amazing how much was dropped here. Fantastic.
|
🥹 Looks great. There's some minor stuff to hash out but it doesn't need to be here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generic serializers that allow for route deduplication.
Closes #198