Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id attribute on <p> elements #197

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix id attribute on <p> elements #197

merged 2 commits into from
Jan 29, 2025

Conversation

jacobtylerwalls
Copy link
Member

Follow-up to 7cec0ec.

Some of these got botched in a find/replace mishap.

johnatawnclementawn
johnatawnclementawn approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@johnatawnclementawn johnatawnclementawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made small change to non-localized string because primevue's implementation doesn't support aria-labeled by

Passes accessibility wave audit 👍🏼

@jacobtylerwalls jacobtylerwalls merged commit d2e67be into main Jan 29, 2025
6 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/fix-p branch January 29, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnatawnclementawn johnatawnclementawn johnatawnclementawn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @johnatawnclementawn