Change lists in resource relationships widget #186
+334
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom node configuration and database
…urces from node configuration and database
…urces from node configuration and database
…urces from node configuration and database
chrabyrd
reviewed
Jan 27, 2025
arches_lingo/src/arches_lingo/components/scheme/report/SchemeStandard.vue
Outdated
Show resolved
Hide resolved
...o/components/generic/resource-instance-relationships/ResourceInstanceRelationshipsEditor.vue
Outdated
Show resolved
Hide resolved
...o/components/generic/resource-instance-relationships/ResourceInstanceRelationshipsEditor.vue
Show resolved
Hide resolved
...o/components/generic/resource-instance-relationships/ResourceInstanceRelationshipsEditor.vue
Show resolved
Hide resolved
...o/components/generic/resource-instance-relationships/ResourceInstanceRelationshipsEditor.vue
Outdated
Show resolved
Hide resolved
...o/components/generic/resource-instance-relationships/ResourceInstanceRelationshipsEditor.vue
Outdated
Show resolved
Hide resolved
...o/components/generic/resource-instance-relationships/ResourceInstanceRelationshipsEditor.vue
Show resolved
Hide resolved
...o/components/generic/resource-instance-relationships/ResourceInstanceRelationshipsEditor.vue
Outdated
Show resolved
Hide resolved
…urces from node configuration and database
…urces from node configuration and database
chrabyrd
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Thanks for addressing the previous stuff. Overall this is looking good but I've noticed a 2 things:
1 . it looks like there's an extra ( blank ) row? I can verify that there's only 1 resource:
- looks like the selection box has fit-content or something with the width -- it changes width depending on what's selected. I can see that biting us in the future potentially, would recommend a static width
|
@chrabyrd re: your second comment, the selection box doesn't expand to fit content, it's static. See this screenshot for some super wide idioms. It does scroll right and left so you can see the rest of the phrase. LMK if that's not desired behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widget now fetches its own resource lists based on graph and node slugs. Adds new footer to create new resources, which opens an empty dialog.