Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds observation type input to workflow steps #1449 #1450

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

chrabyrd
Copy link
Contributor

No description provided.

@chrabyrd chrabyrd changed the base branch from master to dev/1.1.x November 20, 2023 21:01
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; it adds the observation type tile as expected. However, if a user advances to the next step, and then returns to the observation step and changes the value, the change is not reflected in the tile.

@chrabyrd
Copy link
Contributor Author

chrabyrd commented Nov 21, 2023

This looks good; it adds the observation type tile as expected. However, if a user advances to the next step, and then returns to the observation step and changes the value, the change is not reflected in the tile.

@chiatt This is symptomatic of a larger issue. If a user completes the step then goes back and changes a value in the step, instead of the change being applied to the tile, a second tile is created. I will fix the observation tiles/steps as part of this ticket but we should file a follow-up ticket to check/correct all steps for this behavior.

@chiatt
Copy link
Member

chiatt commented Nov 21, 2023

This looks good; it adds the observation type tile as expected. However, if a user advances to the next step, and then returns to the observation step and changes the value, the change is not reflected in the tile.

@chiatt This is symptomatic of a larger issue. If a user completes the step then goes back and changes a value in the step, instead of the change being applied to the tile, a second tile is created. I will fix the observation tiles/steps as part of this ticket but we should file a follow-up ticket to check/correct all steps for this behavior.

#1451

@chrabyrd
Copy link
Contributor Author

This looks good; it adds the observation type tile as expected. However, if a user advances to the next step, and then returns to the observation step and changes the value, the change is not reflected in the tile.

@chiatt resolved in latest 👍

@chiatt chiatt merged commit e481b30 into dev/1.1.x Nov 22, 2023
1 check passed
@chiatt chiatt deleted the 1449-cbyrd-add-observation-type-input branch November 22, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants