Create digital resources for the manifests and the canvases, #1438 #1439
Conversation
| self.saveSamplingActivityDigitalReference(data.resourceinstance_id); | ||
| $.getJSON( arches.urls.api_card + digitalResourcesResourceId ) | ||
| .then(function(data) { | ||
| console.log(data); |
| @@ -240,7 +249,7 @@ define([ | |||
| }); | |||
| }; | |||
|
|
|||
| this.getThumnail = function(digitalResourceData) { | |||
| this.getThumbnail = function(digitalResourceData) { | |||
arches_for_science/models.py
Outdated
| try: | ||
| statement_tile = Tile.objects.filter(nodegroup_id=statement_nodegroupid, resourceinstance_id=resource_id)[0] | ||
| except: |
There was a problem hiding this comment.
Shouldn't this except ObjectDoesNotExist?
arches_for_science/models.py
Outdated
| manifest_data = instance.manifest | ||
| if created: | ||
| create_manifest_digitla_resource(manifest_data, instance.transactionid) |
| @receiver(post_save, sender=IIIFManifest) | ||
| def create_digital_resources(sender, instance, created, **kwargs): | ||
| from arches_for_science.utils.digital_resource_for_manifest import digital_resources_for_manifest, digital_resources_for_canvases |
There was a problem hiding this comment.
Do these imports not work from the top of the file?
There was a problem hiding this comment.
The functions are importing the models (from this file). So, I didn't find a way to avoid the circular import.
There was a problem hiding this comment.
This is looking really good @njkim. It works great for me in the manifest manager. In the Sample Taking workflow the digital resources are created as expected, but I get the following error when trying to save and continue through the workflow:
| digital_resources_for_canvases(instance) |
There was a problem hiding this comment.
This should be wrapped in a transaction
| @receiver(post_delete, sender=IIIFManifest) | ||
| def delete_manifest_x_canvas(sender, instance, **kwargs): | ||
| ManifestXCanvas.objects.filter(manifest=instance.manifest["@id"]).delete() |
There was a problem hiding this comment.
Probably also good to wrap in a transaction
| """ | ||
| Creates the digital resources resource instance representing manifest | ||
| and also creates the manifest_x_canvas record |
There was a problem hiding this comment.
Nice that you added the doc strings, but we should format them like this: https://peps.python.org/pep-0257/#multi-line-docstrings
| """ | ||
| the main function to crate/update the digital resource for the manifest | ||
| """ |
There was a problem hiding this comment.
One line doc strings like this: https://peps.python.org/pep-0257/#one-line-docstrings
Also, create has a small typo.
There was a problem hiding this comment.
Good to know, thanks.
|
|
||
| def digital_resources_for_canvases(instance): | ||
| """ | ||
| the main function to crate/update the digital resource for the canvases |
Add receiver to create digital resources resource instances for the manifests and the canvases.
The pr is dependent on archesproject/arches#10261
Three db tables are added:
If manifest is added:
If manifest is deleted:
If canvas is added to a manifest
If canvas is removed from a manifest
Note,