Skip to content

Commit

Permalink
use editable install for unit tests
Browse files Browse the repository at this point in the history
This appears to be a better practice than testing the code without
installing it. It also simplifies things, because dependencies are
installed automatically by pip.

Explicitly install swig as pycdio build-time dependency, even though
it is installed by default in the GitHub Ubuntu image.
  • Loading branch information
arcctgx committed Nov 1, 2024
1 parent 9136570 commit 2417ec8
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ name: Unit tests

on:
push:
branches:
- master
#branches:
#- master
paths:
- .github/workflows/unit-tests.yml
- arver/**
Expand Down Expand Up @@ -40,24 +40,20 @@ jobs:
- name: Install pycdio dependencies from distribution
run: |
sudo apt-get update
sudo apt-get install -y libcdio-dev libiso9660-dev libdiscid-dev
sudo apt-get install -y libcdio-dev libiso9660-dev libdiscid-dev swig
- name: Install ARver dependencies from distribution
run: |
sudo apt-get install -y libsndfile-dev
- name: Install ARver dependencies from PyPI
- name: Build and install ARver
run: |
python3 --version
python3 -m pip install --upgrade pip
pip3 install --upgrade pip
pip3 install setuptools
pip3 install -r requirements.txt
pip3 install --editable .
pip3 list
- name: Build C extension
run: |
make ext
- name: Run unit tests
run: |
make test

0 comments on commit 2417ec8

Please sign in to comment.