Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub CI Docker Compose Update #86

Merged
merged 1 commit into from
Aug 5, 2024
Merged

GitHub CI Docker Compose Update #86

merged 1 commit into from
Aug 5, 2024

Conversation

mfleader
Copy link
Member

@mfleader mfleader commented Aug 5, 2024

Changes introduced with this PR

Changes to fix removed docker-compose behavior in GitHub CI Runner computing environment.


By contributing to this repository, I agree to the contribution guidelines.

Signed-off-by: Matthew F Leader <[email protected]>
@mfleader mfleader self-assigned this Aug 5, 2024
@mfleader mfleader marked this pull request as ready for review August 5, 2024 15:18
@mfleader mfleader added the bug Something isn't working label Aug 5, 2024
Copy link

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. That's simple. I'd be tempted to think about factoring this out into a "test plugin" that encapsulated the docker compose with the coverage pull, but I wouldn't even want to suggest that level of complication here. 😆

@mfleader mfleader merged commit 047ae3c into main Aug 5, 2024
3 checks passed
@mfleader mfleader deleted the ci_docker-compose branch August 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants