Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination #1419

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Pagination #1419

wants to merge 15 commits into from

Conversation

fadingNA
Copy link
Contributor

@fadingNA fadingNA commented Nov 7, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

New feature add pagination to Setting / Document for user that have uploaded multiple document have pagination to align the documents

Screenshot 2024-11-06 at 10 35 29 PM

@ManishMadan2882 thanks for this.

Copy link

vercel bot commented Nov 7, 2024

@fadingNA is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.96%. Comparing base (0425190) to head (dd9589b).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
application/api/user/routes.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   34.03%   33.96%   -0.08%     
==========================================
  Files          69       69              
  Lines        3376     3386      +10     
==========================================
+ Hits         1149     1150       +1     
- Misses       2227     2236       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 4:46pm

@fadingNA
Copy link
Contributor Author

fadingNA commented Nov 8, 2024

Fixed data fetching, pre calculate pagination data on backend, and passing along with original document for using in another components

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dartpain
Copy link
Contributor

dartpain commented Nov 8, 2024

There are some minor type errors here on build

src/Navigation.tsx(148,26): error TS2339: Property 'find' does not exist on type 'GetDocsResponse'.
src/Navigation.tsx(148,32): error TS7006: Parameter 'doc' implicitly has an 'any' type.
src/hooks/useDefaultDocument.ts(20,15): error TS2339: Property 'forEach' does not exist on type 'GetDocsResponse'.
src/upload/Upload.tsx(169,31): error TS2339: Property 'find' does not exist on type 'GetDocsResponse'.
src/upload/Upload.tsx(169,37): error TS7006: Parameter 'd' implicitly has an 'any' type.
src/upload/Upload.tsx(187,27): error TS2339: Property 'map' does not exist on type 'GetDocsResponse'.
Error: Command "npm run build" exited with 2

@fadingNA
Copy link
Contributor Author

fadingNA commented Nov 8, 2024

There are some minor type errors here on build

src/Navigation.tsx(148,26): error TS2339: Property 'find' does not exist on type 'GetDocsResponse'.
src/Navigation.tsx(148,32): error TS7006: Parameter 'doc' implicitly has an 'any' type.
src/hooks/useDefaultDocument.ts(20,15): error TS2339: Property 'forEach' does not exist on type 'GetDocsResponse'.
src/upload/Upload.tsx(169,31): error TS2339: Property 'find' does not exist on type 'GetDocsResponse'.
src/upload/Upload.tsx(169,37): error TS7006: Parameter 'd' implicitly has an 'any' type.
src/upload/Upload.tsx(187,27): error TS2339: Property 'map' does not exist on type 'GetDocsResponse'.
Error: Command "npm run build" exited with 2

Got it let me fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants