LPS-47551 Validate that a sort can be null #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an debug cobertura agent properly
…that are not indexable/searchable
…work to place into registry for multiple interfaces
…mbers of the parent site" is enabled.
… it will be a sort criteria
Owner
|
these changes look good to me. I think we should be able to handle sorts that are null as long as the indexer's handle it correctly. |
Author
|
Hey @arbetts, I discovered that the Bobo projects does not accept null sort fields. I sent them a PR here: senseidb/bobo#21 Do you think that our Sort implementation must be aware of null SortFields, as are used on this pull? cc/ @arboliveira @ligasm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Andrew, can you review these changes related to the search stuff? You worked on multiple sorts here (LPS-51569) and I'd like to be sure I not work your code. cc/ @juliocamarero @ligasm