-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add package purl in VulnerabilityReport CRD #2311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hown3d
changed the title
feat: add package purl in vuln report
feat: add package purl in *VulnerabilityReport* CRD
Nov 11, 2024
hown3d
changed the title
feat: add package purl in *VulnerabilityReport* CRD
feat: add package purl in VulnerabilityReport CRD
Nov 11, 2024
afdesk
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for your contribution!
@hown3d could you update the PR with the base branch? it should help with tests. thanks! |
Signed-off-by: Lukas Hoehl <[email protected]>
simar7
force-pushed
the
vulnreport-purl
branch
from
November 20, 2024 22:43
9c2d305
to
5ecd1d4
Compare
@simar7 the tests are passed |
simar7
approved these changes
Nov 21, 2024
@hown3d thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds package url (pURL) information into the vulnerability report CRD.
Having the pURL here defines a clear definition of which package this report is actually generated. Also the pURL can be used much better to integrate into other systems.
Since this information is in the trivy scan result anyways it's beneficial to include it in the CR too.
Checklist