Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add package purl in VulnerabilityReport CRD #2311

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

hown3d
Copy link
Contributor

@hown3d hown3d commented Nov 11, 2024

Description

This adds package url (pURL) information into the vulnerability report CRD.
Having the pURL here defines a clear definition of which package this report is actually generated. Also the pURL can be used much better to integrate into other systems.
Since this information is in the trivy scan result anyways it's beneficial to include it in the CR too.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024

CLA assistant check
All committers have signed the CLA.

@hown3d hown3d changed the title feat: add package purl in vuln report feat: add package purl in *VulnerabilityReport* CRD Nov 11, 2024
@hown3d hown3d changed the title feat: add package purl in *VulnerabilityReport* CRD feat: add package purl in VulnerabilityReport CRD Nov 11, 2024
Copy link
Contributor

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for your contribution!

@afdesk
Copy link
Contributor

afdesk commented Nov 20, 2024

@hown3d could you update the PR with the base branch? it should help with tests. thanks!

@afdesk afdesk requested a review from simar7 November 20, 2024 19:35
@simar7
Copy link
Member

simar7 commented Nov 20, 2024

@hown3d could you update the PR with the base branch? it should help with tests. thanks!

@afdesk I just did that but it seems tests are still red.

@afdesk
Copy link
Contributor

afdesk commented Nov 21, 2024

@hown3d could you update the PR with the base branch? it should help with tests. thanks!

@afdesk I just did that but it seems tests are still red.

thanks! I'll take a look

@afdesk
Copy link
Contributor

afdesk commented Nov 21, 2024

@simar7 the tests are passed
could you take another look? thanks

@afdesk afdesk merged commit fadc65c into aquasecurity:main Nov 21, 2024
9 checks passed
@afdesk
Copy link
Contributor

afdesk commented Nov 21, 2024

@hown3d thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants