Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache sbom by image ref #1606

Merged

Conversation

chen-keinan
Copy link
Contributor

@chen-keinan chen-keinan commented Nov 1, 2023

Description

cache sbom by image ref

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@chen-keinan chen-keinan force-pushed the feat/cache-sbom-by-image-ref branch 2 times, most recently from 2895bd8 to 2e8961c Compare November 8, 2023 16:47
@chen-keinan chen-keinan force-pushed the feat/cache-sbom-by-image-ref branch from 4455e00 to 2cc4b41 Compare November 13, 2023 10:26
@chen-keinan chen-keinan force-pushed the feat/cache-sbom-by-image-ref branch from 2cc4b41 to 26dfff8 Compare November 13, 2023 10:27
@chen-keinan chen-keinan marked this pull request as ready for review November 13, 2023 11:01
@chen-keinan chen-keinan merged commit e746309 into aquasecurity:main Nov 13, 2023
8 checks passed
@sathieu
Copy link

sathieu commented Nov 13, 2023

@chen-keinan reading the code, I'm not sure: does is cache vulnerabilityreports by image reference ?

@chen-keinan
Copy link
Contributor Author

chen-keinan commented Nov 13, 2023

@chen-keinan reading the code, I'm not sure: does is cache vulnerabilityreports by image reference ?

@sathieu ImageRef = registry/repo:tag

As I noted in issue, the change is caching sbom by imageRef and vulnerability report is produced from sbom
there is no point to cache vulnerability reports as vulnDB keep changing for same imageRef where sbom is not

@sathieu
Copy link

sathieu commented Nov 13, 2023

@chen-keinan Thanks. This is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Produce Scan results from cached sbom by image Ref Implement "Caching Scan Results by Image Reference"
2 participants