Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make headless service configurable #1562

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

AndreasSchwalb
Copy link
Contributor

@AndreasSchwalb AndreasSchwalb commented Oct 10, 2023

Description

Add headless monitor service configurable

Checklist

  • I've read the guidelines for contributing to this repository.
  • [] I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

For a better usability of the helm chart it may be useful to make the headless service configurable. This is just relevant if you want to export the metrics and scrape them with prometheus.
With this configuration flag, it is not necessary anymore to adjust the service deployment by hand.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2023

CLA assistant check
All committers have signed the CLA.

@chen-keinan chen-keinan changed the title feature: make headless service configurable feat: make headless service configurable Oct 10, 2023
@chen-keinan
Copy link
Contributor

chen-keinan commented Oct 10, 2023

@AndreasSchwalb thank you for the contribution, could you please rebase with upstream and run
mage generate:docs for updating helm docs

Please also sign the CLA

@chen-keinan
Copy link
Contributor

@AndreasSchwalb LGTM 🚀 thanks you for the contribution

@chen-keinan chen-keinan merged commit 3973a4d into aquasecurity:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants