feat(bolt-options): add bolt options to db.Init #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Aug 26, 2024
pkg/db/db.go
Outdated
| @@ -55,7 +55,7 @@ type Operation interface { | |||
| type Config struct { | |||
| } | |||
|
|
|||
| func Init(dbDir string) (err error) { | |||
| func Init(dbDir string, dbOpts *bolt.Options) (err error) { | |||
There was a problem hiding this comment.
Trivy doesn't need bolt.Options. What if using Functional Option Pattern?
e.g.
Lines 34 to 38 in ed690fa
Signed-off-by: knqyf263 <[email protected]>
knqyf263
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#429
add bbolt.Options to db.Init arguments for a more customizable db