Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql install instructions #774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

postgresql install instructions #774

wants to merge 1 commit into from
+14 −10

Conversation

rtso
Copy link
Contributor

@rtso rtso commented Jan 17, 2025 •
edited
Loading

Description

Screenshot 2025-01-17 at 12.50.01 PM.png

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs?
    • Did you update any relative links that pointed to the renamed / removed pages?
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 5:57pm

@rtso Graphite App
Copy link
Contributor Author

rtso commented Jan 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rtso rtso force-pushed the 01-17-postgresql_install branch from 7be2b05 to 3db7939 Compare January 17, 2025 17:49
@rtso rtso changed the title postgresql install postgresql install instructions Jan 17, 2025
@rtso rtso marked this pull request as ready for review January 17, 2025 17:49
@rtso rtso requested a review from a team as a code owner January 17, 2025 17:49
@rtso rtso requested a review from gregnazario January 17, 2025 17:50
graphite-app[bot]
graphite-app bot reviewed Jan 17, 2025
View reviewed changes
apps/nextra/pages/en/build/indexer/indexer-sdk/quickstart.mdx
[PostgreSQL](https://www.postgresql.org/download/)
1. `brew install libpq` ([this is a postgres C API library](https://formulae.brew.sh/formula/libpq)). Also perform all export commands post-installation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instruction to "perform all export commands post-installation" needs to be explicit. After installing libpq, the following exports are typically needed:

export PATH="/opt/homebrew/opt/libpq/bin:$PATH"
export LDFLAGS="-L/opt/homebrew/opt/libpq/lib"
export CPPFLAGS="-I/opt/homebrew/opt/libpq/include"

Consider adding these commands directly to the instructions to ensure consistent setup across environments.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@gregnazario gregnazario Awaiting requested review from gregnazario

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rtso