Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp - add wallet integration guide #732

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

temp - add wallet integration guide #732

wants to merge 1 commit into from

Conversation

gregnazario
Copy link
Collaborator

Description

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs?
    • Did you update any relative links that pointed to the renamed / removed pages?
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 8:56pm

import { Aptos, AptosConfig, Network } from "@aptos-labs/ts-sdk";
const aptos = new Aptos(new AptosConfig(Network.Devnet));
const sender = Account.fromPrivateKey("private key");
const rawTxn = await aptos.transferDigitalAssetTransactions({sender, digitalAssetAddress: "0x1213456", recipient: "0x111111111"}); // List of tokens owned by 0x1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues with this line:

  1. The function name should be transferDigitalAssetTransaction (singular, not plural)
  2. The trailing comment appears to be copied from a different code example - this function transfers a digital asset rather than listing tokens

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Digital Asset transfers are simple. In order to transfer a digital asset, you need to know the address
of the asset (also known as the `token_id`), and the address of the receiver.

To transfer a digital, call `0x1::object::transfer` with the `token_id` and the receiver address.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the word "asset" in this sentence - should read "To transfer a digital asset, call..."

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant