Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not for review] #15619

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Not for review] #15619

wants to merge 4 commits into from

Conversation

vusirikala
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Dec 17, 2024

⏱️ 2h 30m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
test-target-determinator 18m 🟩🟩🟩🟩
execution-performance / test-target-determinator 17m 🟩🟩🟩🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
execution-performance / single-node-performance 13m 🟩🟩🟥🟥
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
fetch-last-released-docker-image-tag 6m 🟩🟩🟩🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩
rust-doc-tests 6m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 4m 🟥
check 3m 🟥🟥🟥🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

@vusirikala vusirikala added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Dec 17, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@vusirikala vusirikala requested a review from bchocho as a code owner December 17, 2024 02:27
@vusirikala vusirikala removed the request for review from bchocho December 17, 2024 02:38

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 306bd1a5c82e3ff9f562550a717484ee5e55b6a8

Compatibility test results for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 306bd1a5c82e3ff9f562550a717484ee5e55b6a8 (PR)
1. Check liveness of validators at old version: 34025227eb5367c449bf9dae3cd226fe5c187904
compatibility::simple-validator-upgrade::liveness-check : committed: 16060.56 txn/s, latency: 2075.41 ms, (p50: 1900 ms, p70: 2100, p90: 2500 ms, p99: 4500 ms), latency samples: 530560
2. Upgrading first Validator to new version: 306bd1a5c82e3ff9f562550a717484ee5e55b6a8
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6102.17 txn/s, latency: 4776.25 ms, (p50: 5500 ms, p70: 5700, p90: 5800 ms, p99: 5900 ms), latency samples: 112960
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5967.04 txn/s, latency: 5451.93 ms, (p50: 5900 ms, p70: 6000, p90: 6000 ms, p99: 6100 ms), latency samples: 210700
3. Upgrading rest of first batch to new version: 306bd1a5c82e3ff9f562550a717484ee5e55b6a8
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6081.52 txn/s, latency: 4680.30 ms, (p50: 5400 ms, p70: 5600, p90: 5700 ms, p99: 5900 ms), latency samples: 112340
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6370.57 txn/s, latency: 5177.01 ms, (p50: 5600 ms, p70: 5700, p90: 5700 ms, p99: 6000 ms), latency samples: 218380
4. upgrading second batch to new version: 306bd1a5c82e3ff9f562550a717484ee5e55b6a8
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10600.04 txn/s, latency: 2626.93 ms, (p50: 3000 ms, p70: 3100, p90: 3200 ms, p99: 3300 ms), latency samples: 185480
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10362.49 txn/s, latency: 3062.43 ms, (p50: 3000 ms, p70: 3300, p90: 3800 ms, p99: 4000 ms), latency samples: 343000
5. check swarm health
Compatibility test for 34025227eb5367c449bf9dae3cd226fe5c187904 ==> 306bd1a5c82e3ff9f562550a717484ee5e55b6a8 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 306bd1a5c82e3ff9f562550a717484ee5e55b6a8

two traffics test: inner traffic : committed: 14243.89 txn/s, latency: 2790.26 ms, (p50: 2700 ms, p70: 2800, p90: 3000 ms, p99: 3300 ms), latency samples: 5415820
two traffics test : committed: 99.91 txn/s, latency: 1400.92 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1700 ms), latency samples: 1660
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.662, avg: 1.612", "ConsensusProposalToOrdered: max: 0.321, avg: 0.299", "ConsensusOrderedToCommit: max: 0.324, avg: 0.313", "ConsensusProposalToCommit: max: 0.621, avg: 0.612"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.55s no progress at version 35639 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.69s no progress at version 2221300 (avg 0.69s) [limit 16].
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant