Add entrypoint environment variable to Docker params#1333
Open
KaneOne wants to merge 1 commit intoappwrite:masterfrom
Open
Add entrypoint environment variable to Docker params#1333KaneOne wants to merge 1 commit intoappwrite:masterfrom
KaneOne wants to merge 1 commit intoappwrite:masterfrom
Conversation
The container runtime has two phases: build and start, but the environment variables passed from outside are lost during dockerStart.
Contributor
WalkthroughAdds the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container runtime has two phases: build and start, but the environment variables passed from outside are lost during dockerStart.
What does this PR do?
The dockerStart method also needs to read environment variables, including entryfile and others.
Summary by CodeRabbit