Skip to content

update: alignment. #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

update: alignment. #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5feead1
update: alignment.
ItzNotABug Feb 3, 2025
f4a38f3
address comment.
ItzNotABug Feb 3, 2025
1080f95
Merge branch 'v2' into fix-helper-alignment
ItzNotABug Feb 3, 2025
f6ef8f9
update: better icon targeting.
ItzNotABug Feb 7, 2025
8df2618
address comment.
ItzNotABug Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions v2/pink-sb/src/lib/Icon.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
class:s={size === 's'}
class:l={size === 'l'}
style:--icon-fill={`var(${color})`}
{...$$restProps}
>
<svelte:component this={icon} />
</i>
Expand Down
5 changes: 3 additions & 2 deletions v2/pink-sb/src/lib/input/Helper.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,15 @@
class:warning={state === 'warning'}
class:error={state === 'error'}
>
<Icon icon={resolveIcon(state)} size="s" />
<Icon icon={resolveIcon(state)} size="s" style="--p-icon-size: 19.6px" />

<slot />
</div>

<style lang="scss">
div {
display: flex;
align-items: center;
align-items: start;
gap: var(--space-3);
color: var(--color-fgcolor-neutral-secondary);

Expand Down
6 changes: 6 additions & 0 deletions v2/pink-sb/src/stories/input/Select.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@
<Story name="Readonly" args={{ readonly: true, value: 'option2' }} />
<Story name="Disabled" args={{ disabled: true }} />
<Story name="Helper" args={{ helper: 'This is a helper text.' }} />
<Story
name="Longer helper"
args={{
helper: 'Lorem ipsum dolor sit amet consectetur adipisicing elit. Quae nisi eveniet neque unde minima id'
}}
/>
<Story name="Helper - success" args={{ state: 'success', helper: 'This is a helper text.' }} />
<Story name="Helper - warning" args={{ state: 'warning', helper: 'This is a helper text.' }} />
<Story name="Helper - error" args={{ state: 'error', helper: 'This is a helper text.' }} />
Loading