-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command center to pink2 #1625
base: feat-pink-v2
Are you sure you want to change the base?
Command center to pink2 #1625
Conversation
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-01-22 12:50:24 CET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending approval from design for the icons change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have a task comment for confirming this change, all icons > arrow right. Will wait for that. Code wise OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we could port more component but it's not urgent
<div class="u-flex u-cross-center u-gap-4"> | ||
<Layout.Stack direction="row" justifyContent="space-between" | ||
><Layout.Stack direction="row" alignItems="center" gap="xxs"> | ||
<kbd class="kbd">Enter</kbd> <span>to select</span></Layout.Stack> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the Keyboard
component on Pink, we can use that one too 👍
What does this PR do?
Update command center to pink v2:
Have you read the Contributing Guidelines on issues?
yes