Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command center to pink2 #1625

Open
wants to merge 3 commits into
base: feat-pink-v2
Choose a base branch
from
Open

Command center to pink2 #1625

wants to merge 3 commits into from

Conversation

ernstmul
Copy link
Contributor

@ernstmul ernstmul commented Jan 22, 2025

What does this PR do?

Update command center to pink v2:
image

Have you read the Contributing Guidelines on issues?

yes

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Jan 22, 2025

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-01-22 12:50:24 CET

Copy link
Member

@ItzNotABug ItzNotABug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending approval from design for the icons change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have a task comment for confirming this change, all icons > arrow right. Will wait for that. Code wise OK.

Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could port more component but it's not urgent

<div class="u-flex u-cross-center u-gap-4">
<Layout.Stack direction="row" justifyContent="space-between"
><Layout.Stack direction="row" alignItems="center" gap="xxs">
<kbd class="kbd">Enter</kbd> <span>to select</span></Layout.Stack>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the Keyboard component on Pink, we can use that one too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants