Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to sentence case #1589

Open
wants to merge 1 commit into
base: feat-pink-v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</script>

<Container>
<ProxyRulesPage rules={data.rules} type={ResourceType.Api} dependency={Dependencies.DOMAINS}>
<svelte:fragment slot="heading">Custom Domains</svelte:fragment>
<ProxyRulesPage rules={data.rules} type={ResourceType.Site} dependency={Dependencies.DOMAINS}>
Copy link
Member

@ItzNotABug ItzNotABug Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come project api domains to site domains?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResourceType.Api doesn't exist anymore:

export enum ResourceType {
    Function = 'function',
    Site = 'site',
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehh, the sdk model needs to be re-generated I guess. If we use ResourceType.Site, site domains would show up in project settings, which doesn't sound correct to me.

<svelte:fragment slot="heading">Custom domains</svelte:fragment>
</ProxyRulesPage>
</Container>
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
{
href: `${path}/domains`,
title: 'Custom Domains',
title: 'Custom domains',
event: 'domains'
},
{
Expand Down
Loading