feat: dropping the notifications from the module and using an optional sns topic #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Review Status
Working Directory: |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the budget notifications configuration by removing the separate notifications input and consolidating notification details within the budgets configuration, while making SNS topic creation optional.
- Removed the standalone notifications configuration block.
- Updated the budgets input to include a singular "notification" field with a default of null.
- Retained SNS topic related inputs for optional SNS topic creation.
Files not reviewed (3)
- modules/budgets/locals.tf: Language not supported
- modules/budgets/main.tf: Language not supported
- modules/budgets/variables.tf: Language not supported
Comments suppressed due to low confidence (1)
modules/budgets/README.md:119
- The separate notifications input is removed. Please ensure the documentation clearly explains that notification configuration is now handled via the single 'notification' field within the budgets input and update any migration notes accordingly.
| <a name="input_notifications"></a> [notifications](#input_notifications) | The configuration as to how the budget notifications should be sent | ... | n/a | yes |
| | <a name="input_tags"></a> [tags](#input\_tags) | A map of tags to add to all resources | `map(string)` | n/a | yes | | ||
| | <a name="input_budgets"></a> [budgets](#input\_budgets) | A collection of budgets to provision | <pre>list(object({<br/> name = string<br/> budget_type = optional(string, "COST")<br/> limit_amount = optional(string, "100.0")<br/> limit_unit = optional(string, "PERCENTAGE")<br/> time_unit = optional(string, "MONTHLY")<br/><br/> notification = optional(object({<br/> comparison_operator = string<br/> threshold = number<br/> threshold_type = string<br/> notification_type = string<br/> }), null)<br/><br/> auto_adjust_data = optional(list(object({<br/> auto_adjust_type = string<br/> })), [])<br/><br/> cost_filter = optional(map(object({<br/> values = list(string)<br/> })), {})<br/><br/> cost_types = optional(object({<br/> include_credit = optional(bool, false)<br/> include_discount = optional(bool, false)<br/> include_other_subscription = optional(bool, false)<br/> include_recurring = optional(bool, false)<br/> include_refund = optional(bool, false)<br/> include_subscription = optional(bool, false)<br/> include_support = optional(bool, false)<br/> include_tax = optional(bool, false)<br/> include_upfront = optional(bool, false)<br/> use_blended = optional(bool, false)<br/> }), {<br/> include_credit = false<br/> include_discount = false<br/> include_other_subscription = false<br/> include_recurring = false<br/> include_refund = false<br/> include_subscription = true<br/> include_support = false<br/> include_tax = false<br/> include_upfront = false<br/> use_blended = false<br/> })<br/><br/> tags = optional(map(string), {})<br/> }))</pre> | `[]` | no | |
There was a problem hiding this comment.
Changing the field from plural 'notifications' with a default of an empty map to a singular 'notification' with a default of null may be a breaking change for consumers. Please ensure that the API changes are clearly documented with appropriate migration instructions if needed.
Copilot uses AI. Check for mistakes.
Pull Request Review Status
Working Directory: |
KashifSaadat
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.