Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix for Context property pane 1 #36342

Closed
wants to merge 2 commits into from
Closed

test: fix for Context property pane 1 #36342

wants to merge 2 commits into from

Conversation

NandanAnantharamu
Copy link
Collaborator

@NandanAnantharamu NandanAnantharamu commented Sep 16, 2024 •
edited
Loading

EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5159

RCA:
The property section related validations were not working

Solution:

Enhanced verification of property pane section visibility using accessibility attributes.
Introduced new UI interaction properties for managing collapsible sections.

/ok-to-test tags="@tag.IDE"

@NandanAnantharamu
Copy link
Collaborator Author

/ci-test-limit

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 16, 2024 •
edited
Loading

Walkthrough

The pull request introduces modifications to the verifyPropertyPaneSectionState function in the Canvas_Context_Property_Pane_1_spec.js file, transitioning from checking for a chevron icon to utilizing the aria-hidden attribute for determining section visibility. Additionally, the limited-tests.txt file is updated to replace a test for "Fork_Template_spec.js" with one for "Canvas_Context_Property_Pane_1_spec.js," indicating a shift in testing focus.

Changes

File(s) Change Summary
app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js Updated the verifyPropertyPaneSectionState function to check the aria-hidden attribute instead of the chevron icon for determining if a section is open or closed.
app/client/cypress/limited-tests.txt Replaced the entry for Fork_Template_spec.js with Canvas_Context_Property_Pane_1_spec.js, changing the focus of limited tests from the fork template functionality to the canvas context property pane functionality.

Possibly related PRs

Suggested labels

Bug, ok-to-test

Poem

In the realm of code where tests reside,
A shift in focus, with changes applied.
From chevrons to attributes, we now see,
A clearer path for accessibility.
With each little tweak, our tests grow bright,
Ensuring our canvas shines with delight! 🌟

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4c7ce27 and 0943b11.

Files selected for processing (2)
  • app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js (1 hunks)
  • app/client/cypress/limited-tests.txt (1 hunks)
Additional context used
Path-based instructions (2)
app/client/cypress/limited-tests.txt (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

  • Follow best practices for Cypress code and e2e automation.
  • Avoid using cy.wait in code.
  • Avoid using cy.pause in code.
  • Avoid using agHelper.sleep().
  • Use locator variables for locators and do not use plain strings.
  • Use data-* attributes for selectors.
  • Avoid Xpaths, Attributes and CSS path.
  • Avoid selectors like .btn.submit or button[type=submit].
  • Perform logins via API with LoginFromAPI.
  • Perform logout via API with LogOutviaAPI.
  • Perform signup via API with SignupFromAPI.
  • Avoid using it.only.
  • Avoid using after and aftereach in test cases.
  • Use multiple assertions for expect statements.
  • Avoid using strings for assertions.
  • Do not use duplicate filenames even with different paths.
  • Avoid using agHelper.Sleep, this.Sleep in any file in code.
app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

  • Follow best practices for Cypress code and e2e automation.
  • Avoid using cy.wait in code.
  • Avoid using cy.pause in code.
  • Avoid using agHelper.sleep().
  • Use locator variables for locators and do not use plain strings.
  • Use data-* attributes for selectors.
  • Avoid Xpaths, Attributes and CSS path.
  • Avoid selectors like .btn.submit or button[type=submit].
  • Perform logins via API with LoginFromAPI.
  • Perform logout via API with LogOutviaAPI.
  • Perform signup via API with SignupFromAPI.
  • Avoid using it.only.
  • Avoid using after and aftereach in test cases.
  • Use multiple assertions for expect statements.
  • Avoid using strings for assertions.
  • Do not use duplicate filenames even with different paths.
  • Avoid using agHelper.Sleep, this.Sleep in any file in code.
Additional comments not posted (2)
app/client/cypress/limited-tests.txt (1)

2-2: Good work, the change aligns with the PR objective! 👍

The modification to focus the limited test run on the canvas context property pane test file is in line with the PR objective.

Just a friendly reminder to ensure that the new test file provides adequate coverage for the changes made in this PR. It's important to maintain a high level of test coverage to catch any potential issues early on. 🎯

app/client/cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Property_Pane_1_spec.js (1)

214-221: Great job utilizing ARIA attributes for state verification! 👍

Class, the changes made to the verifyPropertyPaneSectionState function are a step in the right direction. By relying on the aria-hidden attribute to determine the state of the section's collapse body, we are enhancing accessibility compliance and providing a clearer indication of the section's state.

This approach is more robust compared to the previous implementation that relied on the presence of a visual icon. Using semantic attributes like ARIA ensures that the state verification is reliable and aligns with accessibility best practices.

Keep up the good work in making our code more inclusive and accessible! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Sep 16, 2024
@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10881518219.
Cypress dashboard
PR: #36342.

@NandanAnantharamu
Copy link
Collaborator Author

/ci-test-limit

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10881545472.
Cypress dashboard
PR: #36342.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10881545472.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@NandanAnantharamu
Copy link
Collaborator Author

/ci-test-limit-count run_count=25

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10882036089.
Cypress dashboard
PR: #36342.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10882036089.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 225 Total Passed: 225 Total Failed: 0 Total Skipped: 0 *****************************

@NandanAnantharamu
Copy link
Collaborator Author

closing this as its redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ApekshaBhosale ApekshaBhosale Awaiting requested review from ApekshaBhosale ApekshaBhosale is a code owner

@sagar-qa007 sagar-qa007 Awaiting requested review from sagar-qa007 sagar-qa007 is a code owner

Assignees
No one assigned
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NandanAnantharamu