Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refer release base image on pg branch #36322

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

abhvsn
Copy link
Contributor

@abhvsn abhvsn commented Sep 15, 2024

Description

As we are referring to the same Postgres version on both the pg and release branches we can just reuse the same base image for both release and pg tag. This PR removes the requirement to maintain separate base tag for the pg branch.

/test Sanity

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10869515341
Commit: 1c7051a
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Sun, 15 Sep 2024 08:47:43 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Streamlined the logic for determining the base tag in the build process, simplifying the conditions for setting the base_tag variable.

@abhvsn abhvsn self-assigned this Sep 15, 2024
Copy link
Contributor

coderabbitai bot commented Sep 15, 2024

Walkthrough

The changes in the workflow file focus on simplifying the logic for determining the base_tag variable. The previous conditions based on is-pg-build and github.ref_name have been streamlined. Now, base_tag is assigned to release under specific conditions, while nightly is set only when github.ref_name is master. This adjustment enhances the clarity of the logic without altering any exported or public entity declarations.

Changes

Files Change Summary
.github/workflows/build-docker-image.yml Simplified logic for determining base_tag: now directly assigns release or nightly based on fewer conditions.

Suggested labels

skip-changelog, ok-to-test

🎉 In the code's dance, a change so bright,
Logic refined, now clearer in sight.
Base tags simplified, a smoother flow,
Release or nightly, watch it glow!
Cheers to the code, a joyful embrace,
Progress is made at a steady pace! 🎊


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ba6fd9b and 1c7051a.

Files selected for processing (1)
  • .github/workflows/build-docker-image.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/build-docker-image.yml (1)

87-87: Great work on simplifying the base image tag logic! 👍

The changes in this code segment align perfectly with the PR objective of using the same base image for both the pg and release branches. By removing the condition for setting base_tag to pg and using release as the default value, you have streamlined the process and reduced potential overhead.

The updated logic is clear and concise, making it easier to understand and maintain. Keep up the excellent work! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@abhvsn abhvsn added the ok-to-test Required label for CI label Sep 15, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 15, 2024
@abhvsn abhvsn merged commit a397c55 into release Sep 17, 2024
49 checks passed
@abhvsn abhvsn deleted the chore/remove-pg-base-image branch September 17, 2024 13:01
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
## Description
As we are referring to the same Postgres version on both the pg and
release branches we can just reuse the same base image for both release
and pg tag. This PR removes the requirement to maintain separate base
tag for the pg branch.

/test Sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10869515341>
> Commit: 1c7051a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10869515341&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Sun, 15 Sep 2024 08:47:43 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Streamlined the logic for determining the base tag in the build
process, simplifying the conditions for setting the `base_tag` variable.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants