Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate into Next.js App Router #353

Merged
merged 15 commits into from
Oct 25, 2023
Merged

feat: Migrate into Next.js App Router #353

merged 15 commits into from
Oct 25, 2023

Conversation

MikuroXina
Copy link
Collaborator

SHUN がいつまで経ってもやらないのでやりました

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 29d3a7a
Status: ✅  Deploy successful!
Preview URL: https://a451d24c.approvers.pages.dev
Branch Preview URL: https://fix-app-router.approvers.pages.dev

View logs

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 9, 2023
View reviewed changes
src/app/blog/[id]/post.tsx Dismissed Show dismissed Hide dismissed
src/app/blog/blog.tsx Dismissed Show dismissed Hide dismissed
src/app/components/footer.tsx Dismissed Show dismissed Hide dismissed
src/app/components/google-analytics.tsx Dismissed Show dismissed Hide dismissed
src/app/components/navigation.tsx Dismissed Show dismissed Hide dismissed
src/app/link/link.tsx Dismissed Show dismissed Hide dismissed
src/app/member/members.tsx Dismissed Show dismissed Hide dismissed
src/app/providers.tsx Dismissed Show dismissed Hide dismissed
src/app/components/google-analytics.tsx Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 9, 2023
View reviewed changes
src/app/blog/[id]/page.tsx Fixed Show fixed Hide fixed
@MikuroXina MikuroXina marked this pull request as ready for review October 9, 2023 18:32
@MikuroXina MikuroXina linked an issue Oct 19, 2023 that may be closed by this pull request
App Routerを使う #336
Closed
shun-shobon
shun-shobon reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@shun-shobon shun-shobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少しだけ修正して欲しいところがありましたが、概ね良さそうです。ありがとうございます。

src/app/blog/[id]/page.tsx Outdated Show resolved Hide resolved
src/app/blog/blog.tsx Outdated Show resolved Hide resolved
src/app/layout.tsx Outdated Show resolved Hide resolved
shun-shobon
shun-shobon approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@shun-shobon shun-shobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいと思います。お疲れ様でした & ありがとうございました！

@MikuroXina MikuroXina merged commit ec340d6 into main Oct 25, 2023
6 checks passed
@MikuroXina MikuroXina deleted the fix/app-router branch October 25, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shun-shobon shun-shobon shun-shobon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App Routerを使う
2 participants
@MikuroXina @shun-shobon