Use discordId as key

approvers · Oct 2, 2023 · 23153d6 · 23153d6
1 parent 4828e4b
commit 23153d6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/lib/member-fetch.ts b/src/lib/member-fetch.ts
@@ -27,6 +27,7 @@ function validateSNSLinks(links: unknown): links is readonly SNSLinkInfo[] {
 
 export type Member = {
   username: string;
+  discordId: string;
   associatedLinks: readonly SNSLinkInfo[];
 };
 
@@ -37,7 +38,11 @@ function validateMember(obj: unknown): obj is Member {
   }
 
   if (typeof (obj as Member).username !== "string") {
-    console.error("`avatar` not in: ", obj);
+    console.error("`username` not in: ", obj);
+    return false;
+  }
+  if (typeof (obj as Member).discordId !== "string") {
+    console.error("`discordId` not in: ", obj);
     return false;
   }
   if (!validateSNSLinks((obj as Member).associatedLinks)) {

diff --git a/src/pages/member.tsx b/src/pages/member.tsx
@@ -55,7 +55,7 @@ const MembersPage: NextPage<MembersPageProps> = ({ members }) => {
       <Title>メンバー紹介</Title>
       <Grid gap={2} templateColumns="repeat(auto-fill, minmax(15em, 1fr))">
         {members.map((member) => (
-          <GridItem key={member.username} borderRadius="3xl" bgColor={cardBg}>
+          <GridItem key={member.discordId} borderRadius="3xl" bgColor={cardBg}>
             <MemberCard {...member} />
           </GridItem>
         ))}