Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send dont_have when retrieval immediately fails #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rvagg
Copy link
Collaborator

@rvagg rvagg commented Jan 25, 2023

Maybe an alternative to just doing #169. I wonder if not playing nicely with clients will be impacting what we're receiving?

Sending immediate dont_haves rather than relying on the AwaitGet call to return for cases where the indexer says there might help since they are the most common responses.

I'm doing something like this in #167 already.

@codecov-commenter
Copy link

Codecov Report

Base: 4.87% // Head: 4.86% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6b0ae1f) compared to base (0eeef5d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #170      +/-   ##
=========================================
- Coverage    4.87%   4.86%   -0.02%     
=========================================
  Files          15      15              
  Lines        1723    1727       +4     
=========================================
  Hits           84      84              
- Misses       1634    1638       +4     
  Partials        5       5              
Impacted Files Coverage Δ
bitswap/provider.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants