Support type: 'null'
as OpenAPIValueContainer
#557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
OpenAPIKit's handling of
type: 'null'
was problematic with older Yams versions. See https://github.com/mattpolzin/OpenAPIKit/pull/366/files for a test demonstrating that & dependency version bump.Similarly, swift-openapi-generator explicitly does not "support"
type: 'null'
. As part of searching for something to address #513 I have added such support for explicit nulls. This gives one more sort of input schema where swift-openapi-generator produces some useful output instead of skipping a schema.Modifications
true
fromisSchemaSupported
fortype: 'null'
schemas..null
to have a builtint ype ofOpenAPIValueContainer
Result
Nothing should change for existing users because
type: null
schemas were previously unsupported. Going forward, usages of these schemas is supported.Test Plan
New test included.