Combine the two NIOAsyncChannel channel handlers #2779

glbrntt · 2024-07-10T14:28:43Z

Motivation:

The NIOAsyncChannel allocates 12 times on init. 4 of these allocations come from creating two channel handlers and two channel handler contexts. There's no inherent reason that these channel handlers can't be combined to eliminate two allocations (one handler and one context).

Modifications:

Combine NIOAsyncChannelInboundStreamChannelHandler and NIOAsyncChannelOutboundWriterHandler into a single NIOAsyncChannelHandler. Most of this was straightforward as only a few handler operations were duplicated across both.
Add a 'NIOAsyncChannelHandlerWriterDelegate' in place of the 'NIOAsyncChannelOutboundWriterHandler.Delegate'. One knock on from this is that the new delegate stores callbacks rather than the concrete type of the handler. This is necessary to prevent the generics from the new channel handler bubbling up to the outbound writer (which would break API and be somewhat odd).

Result:

Fewer allocations

FranzBusch

Nice!

Motivation: The NIOAsyncChannel allocates 12 times on init. 4 of these allocations come from creating two channel handlers and two channel handler contexts. There's no inherent reason that these channel handlers can't be combined to eliminate two allocations (one handler and one context). Modifications: - Combine `NIOAsyncChannelInboundStreamChannelHandler` and `NIOAsyncChannelOutboundWriterHandler` into a single `NIOAsyncChannelHandler`. Most of this was straightforward as only a few handler operations were duplicated across both. - Add a 'NIOAsyncChannelHandlerWriterDelegate' in place of the 'NIOAsyncChannelOutboundWriterHandler.Delegate'. One knock on from this is that the new delegate stores callbacks rather than the concrete type of the handler. This is necessary to prevent the generics from the new channel handler bubbling up to the outbound writer (which would break API and be somewhat odd). Result: Fewer allocations

* apple/main: (26 commits) [GHA] Only format Swift files that are in Git index (apple#2797) Ignore format commit from git blame (apple#2796) Adopt swift-format (apple#2794) Disable warnings as errors on Swift 6 and main (apple#2793) ChannelHandler: provide static (un)wrap(In|Out)bound(In|Out) (apple#2791) Add manual control to NIOLockedValueBox (apple#2786) [GHA] Cxx interoperability compatibility and integration tests check (apple#2790) [GHA] Introduce reusable matrix workflow (apple#2789) Fix benchmark thresholds update script (apple#2783) [GHA] Broken symlink and format check (apple#2787) [GHA] Add license header check (apple#2781) Improved documentation for HTTP Parts to clarify how often each part is received (apple#2775) [GHA] Download the scripts to make workflow reusable (apple#2785) Combine the two NIOAsyncChannel channel handlers (apple#2779) [GHA] Benchmark job (apple#2780) [GHA] Move docs check to script (apple#2776) Add benchmark for creating NIOAsyncChannel (apple#2774) Avoid creating a yield ID counter per async writer (apple#2768) [GHA] Unacceptable language check (apple#2766) Allow in-place mutation of `NIOLoopBoundBox.value` (apple#2771) ... # Conflicts: # Sources/NIOPosix/BSDSocketAPICommon.swift # Sources/NIOPosix/GetaddrinfoResolver.swift # Sources/NIOPosix/HappyEyeballs.swift

glbrntt force-pushed the async-channel-handler branch from 89b0877 to 1bcf82f Compare July 10, 2024 14:35

glbrntt marked this pull request as ready for review July 10, 2024 15:07

glbrntt requested a review from FranzBusch July 10, 2024 15:07

glbrntt added the semver/patch No public API change. label Jul 10, 2024

FranzBusch approved these changes Jul 11, 2024

View reviewed changes

glbrntt added 3 commits July 12, 2024 08:18

Update alloc limits

ab6adb4

add nightly main alloc limits

53506cf

glbrntt force-pushed the async-channel-handler branch from 09349b0 to 53506cf Compare July 12, 2024 07:20

glbrntt enabled auto-merge (squash) July 12, 2024 07:21

glbrntt merged commit 0f4c110 into apple:main Jul 12, 2024
21 of 22 checks passed

glbrntt deleted the async-channel-handler branch July 12, 2024 08:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Combine the two NIOAsyncChannel channel handlers #2779

Combine the two NIOAsyncChannel channel handlers #2779

glbrntt commented Jul 10, 2024

FranzBusch left a comment

Combine the two NIOAsyncChannel channel handlers #2779

Combine the two NIOAsyncChannel channel handlers #2779

Conversation

glbrntt commented Jul 10, 2024

FranzBusch left a comment

Choose a reason for hiding this comment