support stream resets through user events #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Dec 16, 2024
| @@ -998,3 +1007,9 @@ extension HTTP2StreamChannel { | |||
| SynchronousOptions(channel: self) | |||
| } | |||
| } | |||
|
|
|||
| /// Events that can be sent by the application to be handled by the `HTTP2StreamChannel` | |||
| public enum HTTP2StreamChannelEvent { | |||
There was a problem hiding this comment.
So I think we'll probably end up regressing making this a public enum, as we can't easily evolve that as an API. I think we should store the "real" value in an enum, but have this wrapped in a struct that has a few static func constructors..
We'll also need tests for this.
|
closing in favor of apple/swift-nio-extras#241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting streams with specific error codes is required by some applications such as those implementing the CONNECT method (see https://datatracker.ietf.org/doc/html/rfc9113#section-8.5-8).
ChannelOutboundInvoker.closedoesn't allow for closing channels while specifying an error code. To get around this, this change defines an eventHTTP2StreamChannelEventwhich allows applications to close the channel with additional detail.