Open
Conversation
Member
|
This should be apart of #379 if we wanna finally review it |
Member
|
Funnily enough v2 has warnings as well |
Contributor
Author
Either works, assuming warnings can be solved in v2. |
Contributor
|
Right now #379 fails hawkeye with: I think I'll have free time this weekend to finally do the last bit of review on that PR |
Member
|
There's a "bug" in the deps on that pr that cause warnings on 6.2, so if we want a warning free build that isn't the move. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves warnings like this in projects that are using Containerization: