Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5 #7515

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Version 5 #7515

wants to merge 26 commits into from

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Apr 18, 2023

Drops support for Node 14 & Node 16

TODO:

  • Node 16 EOL (9/11/23)
  • Docs update / figure out how we talk about v4 + v5 as "the same thing"
  • Change default for status400ForVariableCoercionErrors option
  • Address FIXMEs
  • Get alignment depcrecation / EOL policy for AS4
  • Remove precomputedNonce config option (breaking change)

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit bca644d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/64c803dd103ef70008fb68e1
😎 Deploy Preview https://deploy-preview-7515--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bca644d:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@trevor-scheer trevor-scheer marked this pull request as ready for review April 18, 2023 21:20
"@apollo/utils.keyvaluecache": "^3.0.0",
"@apollo/utils.logger": "^3.0.0",
"@apollo/utils.usagereporting": "^3.0.0",
"@apollo/utils.withrequired": "^3.0.0",
"@graphql-tools/schema": "^9.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to bump this to ^10.0.0 now, too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah a couple major dep updates have stacked up since I started this PR that I'll get merged once I get back to it 👍

@trevor-scheer trevor-scheer requested review from Meschreiber and removed request for StephenBarlow July 28, 2023 21:32
@trevor-scheer
Copy link
Member Author

@Meschreiber this change won't land until at least mid-September but if you can take a look at the documentation changes at some point I would appreciate it!

Copy link
Contributor

@Meschreiber Meschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verbiage updates lgtm. Slight copy edit included.

docs/source/migration.mdx Outdated Show resolved Hide resolved
Co-authored-by: Maria Elisabeth Schreiber <[email protected]>
@benasher44
Copy link

benasher44 commented Nov 28, 2023

Is there a rough ETA for v5 by chance? It'd be great to get this, so we can get the major version graphql-tools updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants