test: implements freezegun to enable freezing of time for testing #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisimcevoy
approved these changes
Nov 15, 2023
| """Test that get_uuid() returns a valid uuid.""" | ||
| UUID(get_uuid()) | ||
| assert UUID(get_uuid()) |
There was a problem hiding this comment.
nab: why use assert?
There was a problem hiding this comment.
It asserts the value is truthy but in highlight that's not a great test either as it still raises a ValueError - instead we should catch the value error and cause pytest to raise an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implements freezegun to enable freezing of time for testing
Changes
This PR implements the following changes: