-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding currency rate for the central bank of Iceland #494
Open
olafurorng
wants to merge
2
commits into
apis-is:master
Choose a base branch
from
olafurorng:currency/central-bank
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* eslint-disable import/first */ | ||
const request = require('request') | ||
const h = require('apis-helpers') | ||
const cheerio = require('cheerio') | ||
const app = require('../../server') | ||
|
||
app.get('/currency/cb', (req, res) => { | ||
request.get({ | ||
headers: { 'User-Agent': h.browser() }, | ||
url: 'https://www.sedlabanki.is/hagtolur/opinber-gengisskraning/', | ||
}, (err, response, body) => { | ||
if (err || response.statusCode !== 200) { | ||
return res.status(500).json({ error: 'www.sedlabanki.is refuses to respond or give back data' }) | ||
} | ||
|
||
const $ = cheerio.load(body) | ||
const currencies = [] | ||
|
||
$('.Gengistafla').first().find('tr').each(function () { | ||
const tds = $(this).find('td') | ||
const name = tds.eq(0).text() | ||
|
||
if (name) { | ||
currencies.push({ | ||
shortName: name, | ||
longName: tds.eq(1).text(), | ||
value: tds.eq(4).text(), | ||
askValue: null, | ||
bidValue: null, | ||
changeCur: null, | ||
changePer: null, | ||
}) | ||
} | ||
}) | ||
|
||
// cache for 15 minutes | ||
return res.cache(900).json({ results: currencies }) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
# Currency in relation to ISK | ||
|
||
Source: [m5.is](http://m5.is/), [Arion banki](https://arionbanki.is/) and [Landsbankinn](https://landsbankinn.is/) | ||
Source: [m5.is](http://m5.is/), [Arion banki](https://arionbanki.is/), [Landsbankinn](https://landsbankinn.is/) and [Central Bank of Iceland](https://www.sedlabanki.is) | ||
|
||
- GET [/currency/:source](https://apis.is/currency/:source) | ||
|
||
Get currency data in relation to ISK | ||
|
||
| Parameters | Description | Example | | ||
|--------------------|---------------------|-----------------------| | ||
| :source (required) | Which source to use | [m5](https://apis.is/currency/m5), [arion](https://apis.is/currency/arion) or [lb](https://apis.is/currency/lb) | | ||
| :source (required) | Which source to use | [m5](https://apis.is/currency/m5), [arion](https://apis.is/currency/arion), [lb](https://apis.is/currency/lb), [cb](https://https://apis.is/currency/cb) | | ||
|
||
|
||
--- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,14 @@ describe('currency', () => { | |
}) | ||
}) | ||
|
||
describe('searching using provider "cb"', () => { | ||
it('should return an array of objects containing correct fields', (done) => { | ||
const params = helpers.testRequestParams('/currency/cb') | ||
const resultHandler = helpers.testRequestHandlerForFields(done, fieldsToCheckFor) | ||
request(params, resultHandler) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing mock data for this test. Here's an example of how to do it: https://github.com/apis-is/apis/blob/1fb161a/endpoints/horses/tests/integration_test.js#L22-L4 |
||
}) | ||
}) | ||
|
||
describe('searching using provider "borgun"', () => { | ||
it('should return an array of objects containing correct fields', (done) => { | ||
const params = helpers.testRequestParams('/currency/borgun') | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the html has changed. The table only has 3 columns now so the indexes in the
tds.eq
calls are wrong.I'm not sure if the
if
on line 23 is still valid now thatname
is from column index 1.