Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Add type safety for global.SwaggerConverter #555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimmycann
Copy link

@jimmycann jimmycann commented Dec 27, 2017

Hi there,

Keep running into this error in a private repo, so I thought I'd add a small check

TypeError: Cannot read property 'convert' of undefined
    at Object.<anonymous> (...src/node_modules/swagger-tools/lib/specs.js:39:46)
    at Module._compile (module.js:635:30)

I haven't yet looked closer as to why swagger-tools is involved in my code to be honest. Swagger is turned off using the enabled: false flag. swagger-tools is a sub dependency of a private library I don't have a lot of control over, so I thought it would be easier to submit a patch here.

It looks like the reason that global variable is coming on for me as undefined is that in the referenced library, swagger-converter, it is declaring SwaggerConverter as a method on window, which I assume would work in the browser, but not in node.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@jimmycann
Copy link
Author

Signed the Google Developer CLA

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants