This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Add type safety for global.SwaggerConverter
#555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Keep running into this error in a private repo, so I thought I'd add a small check
I haven't yet looked closer as to why swagger-tools is involved in my code to be honest. Swagger is turned off using the
enabled: false
flag. swagger-tools is a sub dependency of a private library I don't have a lot of control over, so I thought it would be easier to submit a patch here.It looks like the reason that global variable is coming on for me as undefined is that in the referenced library, swagger-converter, it is declaring
SwaggerConverter
as a method onwindow
, which I assume would work in the browser, but not in node.