-
Notifications
You must be signed in to change notification settings - Fork 370
fixes stream validation #464
base: master
Are you sure you want to change the base?
fixes stream validation #464
Conversation
…ull schema is failing validation. Added code to ensure unit test passes by doing a check if no data is passed to end and no data is written. In this situation some code expects undefined to be passed to the validators. Delay converting response buffers to string as long as possible. Also, don't convert buffers sourced from a file to a string as it'll mess with the encoding. There's nothing to validate on files anyway.
f065acf
to
7f9cb81
Compare
What is the failure for this? Can you wire up an error handler and dump the whole object? (This isn't as easy as |
uh, i don't know what you mean. |
Oh, I got you. I thought stream validation was throwing an error where it wasn't suppose to. Let me look further. |
…stream-response-validation-bug
…eam-response-validation-bug
awh, please! timeout on node 0.12. srsly?! how can i retrigger travis tests? |
Triggered. |
…eam-response-validation-bug
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed it! |
@whitlockjc can you please have a look at master? it seems that the tests fail recently. i checked it out and performed it locally and the same errors occur as of this PR. Thanks |
I'll fix Would you mind submitting something similar for sway? I assume it's got the same issue. |
@whitlockjc |
this test works before 17e77be